[SYCL] Replace direct builtins-side multi_ptr usage with forward-declaration#21687
Open
koparasy wants to merge 4 commits intointel:syclfrom
Open
[SYCL] Replace direct builtins-side multi_ptr usage with forward-declaration#21687koparasy wants to merge 4 commits intointel:syclfrom
koparasy wants to merge 4 commits intointel:syclfrom
Conversation
…lper customization points so <sycl/builtins.hpp> no longer needs to include the full <sycl/multi_ptr.hpp> definition. Preserve multi_ptr builtin behavior once multi_ptr.hpp is included, and update include-deps / regression coverage. On a TU including only <sycl/builtins.hpp> we observe 3.5% reduction for host compilation and 21.7% reduction for device compilation.
koparasy
changed the title
Contributor
Author
PR Note (Breaking Change Awareness)This change removes a transitive include of As a result, code that previously relied on including Impact:Source-breaking for applications that depend on transitive inclusion of Recommended fix for users:Explicitly include Question for reviewers: Should we: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sycl/builtins.hpp>no longer needs to include the full <sycl/multi_ptr.hpp> definition. Preservemulti_ptrbuiltin behavior once multi_ptr.hpp is included, and update include-deps / regression coverage.On a TU including only <sycl/builtins.hpp> we observe 3.5% reduction for host compilation and 21.7% reduction for device compilation.